jbrockmendel

Results 391 comments of jbrockmendel

I came here to request the same thing; found that in pandas we do `np.isfinite(arr).all()` and it'd be nice to short-circuit. (see also https://github.com/pandas-dev/pandas/issues/32339)

+1 on the big picture. Implementation-wise, is the idea to pretty much replace our usage of dateutil.parser?

IIRC I was looking at _metadata to try to implement units (this predated EAs). One of the biggest problems I had was that metadata on a Series didn't behave well...

> What would an EA-based implementation look like? It's a bit ambiguous what this question is referring to, but big picture something like `_metadata` but with dispatch logic could be...

> What's the difference between inplace and setting a new array? Neither the warning, nor the release notes makes this very clear to me. Definitely open to suggestions for better...

test.loc[1] should definitely raise, but it may be that test.index._should_fallback_to_positional should be True, in which case the `__getitem__` call should still work (but would have different behavior on `test[::-1]`)

The relevant logic for `ambiguous="infer"` lives in pandas._libs.tslibs.tz_conversion._get_dst_hours. ATM it is only implemented for dateutil/pytz (zoneinfo goes through the `if info.use_tzlocal:` branch of `tz_localize_to_utc`). It looks like _get_dst_hours relies on...