gonepass icon indicating copy to clipboard operation
gonepass copied to clipboard

Published 20 hours ago • verified publisher icon jbreams

Please add C++11 standard requirement

Open barracuda156 opened this issue 2 years ago • 3 comments

The build fails spectacularly with an older compiler which does not support C++11. CMake should require the standard.

barracuda156 avatar Oct 19 '23 12:10 barracuda156

The C++ standard is set here https://github.com/jbreams/gonepass/blob/3da5cfa120b4e530092d9cda5634e72f22b048d8/CMakeLists.txt#L15, what else needs to be done here?

jbreams avatar Oct 19 '23 13:10 jbreams

@jbreams Thank you for responding!

I think it will be better to have it required: https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD_REQUIRED.html Otherwise somebody gets a failure and won’t immediately know why.

barracuda156 avatar Oct 19 '23 13:10 barracuda156

@jbreams FYI, I have added it to Macports: https://ports.macports.org/port/gonepass/details

barracuda156 avatar Oct 19 '23 14:10 barracuda156