John Bowler

> I sent the changelist to Chrome's commit queue dry run. I will report back if it passes Chrome's test suite. Yes, that's what I wanted. A full build test...

Oh, it's the other bug you mentioned. Here's one of the results: ``` [ RUN ] StaticPNGTests.ColorType2TrnsBeforePlte ../../third_party/blink/renderer/platform/image-decoders/png/png_image_decoder_test.cc:1137: Failure Value of: frame->HasAlpha() Actual: false Expected: true ``` So, in fact,...

> The crash occurs at `pngimage.c:1249`. From what I understood so far (and, mind you, my understanding at this moment may or may not be correct) we have a 4bpp...

pngimage fails in both HEAD and libpng-1.6.24-signed on that file, but it is a regular failure at line 24 (IRC how to decode the error message). I don't know if...

The sBIT/SHIFT code was backported from 1.7 and never gets invoked in 1.6. The original path did, indeed, use memcmp on 'rowbytes', the other (else) path should be using rowbytes...

This issue should be closed; the original reporter has dropped the ball.

That's why I wrote safecat; people do this all the time. I.e. update a message and don't increase the length of the corresponding buffer or do the addition wrong. It's...

This is what I want to see for libpng-ng; i.e. a rewrite which uses a full error code scheme, either 'true/false' with separate error codes or segmented error codes (like...

@d3xor I suggest you launch a discussion on png-mng-implement.

@d3x0r one of my current points of focus is the extent to which application and library developers find the simplified API inadequate. In view of this you are the perfect...