John Bowler

I deleted my previous comment. Visiting this shit on Mark is inappropriate, Mark: accept my apologies if that was the result.

@wwwillem you may care to comment. The program immediately exits after the setjmp returns non-zero, but then why call png_destroy_read_struct? It's valid in ANSI-C to do so because png_ptr is...

The first change is correct but hardly matters; this is documentation, not code. The second change appears to be wrong and misleading; the point of the code is to protect...

@ctruta the original bug reporters where using code built on the API for libpng 1.2 and tried to compile it against a version of libpng where the png_struct and png_info...

> Yes, effectively, that's not ok to use FILE pointer where it wasn't created. Right, but my suggestion (which doesn't really work for reasons I will explain) was to remove...

> OTOH libpng-ng is a good opportunity for us to break our current big and giant `png*.c` source files into smaller and more manageable ones. Certainly. 10,000 line files are...

That's not the whole picture, take a look at the code of src/libespeak-ng/tr_languages.c ``` $ wc src/libespeak-ng/tr_languages.c 1658 8976 72076 src/libespeak-ng/tr_languages.c ``` It's crude but if I look at the...

Hum... apart from, perhaps, Bosnian it seems to me that it would be possible to enable/disable languages in automake. That's not going to help Windows users but it would allow...

So far as what @jaacoppi suggests it's pretty trivial to try - just remove src/libespeak-ng/compile*.c from the source files for the library/DLL... I just tested it, the library builds with...

You don't remove the files, rather you modify Makefile.am not to include them in the build; i.e. delete the three lines: ``` src/libespeak-ng/compiledata.c \ src/libespeak-ng/compiledict.c \ src/libespeak-ng/compilembrola.c \ ``` from...