John Bowler

Results 207 comments of John Bowler

> @jbowler Hi, I have provided the PoC program and PoC input at: [timeout_poc.tar.gz] You need to remove that file, it is reported by Chrome as containing a virus. I've...

But apart from that your code is wrong; your read function does no error handling so when it reaches the end of the file (which it does because the enormous...

This is a bug in your application. row_stride is passed to all those functions. It has to be correct. If there is a bug in the read code please report...

The warning indicates that a chunk (sRGB in this case) is in the wrong place in the PNG file/datastream. The file or stream needs to be fixed. The sRGB chunk...

This is nothing to do with libpng; libpng makes a function call in response to an image with a detectably misplaced chunk (sRGB in this case). You need to identify...

@ctruta - not-a-bug, by-design, as-intended, etc. On the other hand if the WC3 current proposals are accepted pngtest.png will become an invalid PNG. I suggest that libpng get out of...

> Using libpng with [FetchContent](https://cmake.org/cmake/help/latest/module/FetchContent.html) does not work because header files are missing. I am using Windows 10 and I don't have libpng installed elsewhere. Does FetchContent work correctly in...

To quote the manual for png_read_png: **"You must use png_transforms[the parameter to png_read_png] and not call any png_set_transform() functions when you use png_read_png."** Here's a patch that detects the error....

This is an app bug, not a libpng png. png_read_update_info can only be called once and must not be called with png_read_png because png_read_png has to call it after setting...

This patch adds app_error or app_warning to the pngtrans.c function. app_warning is used in cases where I believe the application error won't result in miscalculation of the row sizes. It...