JBotSim icon indicating copy to clipboard operation
JBotSim copied to clipboard

TopologyGenerators.generateRing() does not position the nodes correctly

Open acasteigts opened this issue 4 years ago • 3 comments

When creating nodes with TopologyGenerators.generateRing(), the nodes are not well placed correctly, as witnessed by the attached picture. ring

acasteigts avatar Nov 03 '21 17:11 acasteigts

Cause of the problem: TopologyGenerators.generateRing() had incoherent positioning and dimensioning values.

Fix: A new method, which centers the shape in the Topology and sizes it to secure a margin. Bonus: for consistency sake, TopologyGenerators.generateKN() now also uses that method.

remikey avatar Nov 04 '21 19:11 remikey

@acasteigts , please have a look at branch fix/111-topologygenerators-generateRing-positioning.

Note: It is not based on develop, but on the branch which fixes #108 .

remikey avatar Nov 04 '21 19:11 remikey

merged into develop.

remikey avatar Nov 15 '21 19:11 remikey