JBotSim icon indicating copy to clipboard operation
JBotSim copied to clipboard

Message.toString() should include the flag

Open acasteigts opened this issue 4 years ago • 5 comments

The current version of Message.toString() shows only the content of the message, not its flag, which should be added.

acasteigts avatar Oct 06 '21 16:10 acasteigts

What's been done in branch feature/105-message-to-string-flag:

  • The Flag is now present in the String representation of a Message
  • The nodes IDs are used in this representation

Merged into develop.

acasteigts avatar Oct 06 '21 18:10 acasteigts

(Will be closed when released.)

acasteigts avatar Oct 16 '21 11:10 acasteigts

After discussions:

  • The use of Node.toString() in Message.toString() was restored, instead of Node.getID().
  • The inclusion of the flag is still added.

acasteigts avatar Nov 03 '21 17:11 acasteigts

@acasteigts, I took the liberty to slightly modify your Changelog commit to try and minimize discrepancies with the rest of the file.

Otherwise, ok for me.

remikey avatar Nov 04 '21 18:11 remikey

merged into develop.

remikey avatar Nov 04 '21 18:11 remikey