jboss-modules [MODULES-447] Make the ModuleLoggerFinder.activate() method public. A…

…lso, activate the ModuleLoggerFinder if a threshold is hit.

https://issues.redhat.com/browse/MODULES-447

Upstream #328

Feb 23 '24 02:02 jamezp

I've updated this and #328 to both just activate logging if the threshold is hit. I feel like for logging we need to activate, but I also understand it might make the log messages look weird. For example, the date will definitely not be that friendly. However, they are log messages and I don't think we can just discard them. We have to do something.

Another option might be to add the timestamp to the SimpleLogRecord and if not activated promptly, default activation would be writing to System.out in some formatted pattern.

Mar 01 '24 16:03 jamezp

can we merge this if it is what we wanted ? thanks

Mar 20 '24 09:03 gaol

@dmlloyd @ropalka may I ask one of you to check this please ? thanks

Mar 27 '24 03:03 gaol

We are not likely going to use this solution. Discussion is ongoing regarding a potential bootstrap API which would be the replacement. It's not fully decided yet though.

Mar 27 '24 11:03 dmlloyd

FWIW this is now just a solution which drains the queue if it reaches an arbitrary size. We could make the size configurable with a system property.

Mar 27 '24 12:03 jamezp