javassist icon indicating copy to clipboard operation
javassist copied to clipboard

java.rmi package used in tests is deprecated

Open zmiklank opened this issue 2 years ago • 3 comments

The java.rmi package has been deprecated and is now completely removed from the future versions of java[1], AFAIK from jdk17. There is no replacement for the RMI mechanism. Javassist uses this package only in its test suite, here are listed the dependent tests:

src/test/test2/Inner.java
src/test/javassist/JvstTest.java
src/test/javassist/JvstTest2.java
src/test/javassist/JvstTest3.java
src/test/javassist/bytecode/StackMapTest.java
src/test/javassist/bytecode/BytecodeTest.java

Is there any plan for the future for removing the deprecated dependency, so that the test could be compiled with jdk17?

[1] https://docs.oracle.com/en/java/javase/15/docs/api/java.rmi/java/rmi/activation/package-summary.html

zmiklank avatar May 10 '22 11:05 zmiklank

The code dependent on java.rmi will be removed. java.rmi in src/test/test2/Inner.java has been already removed. I could not see java.rmi in JvstTest3.java, StackMapTest.java, or BytecodeTest.java. What am I missing?

chibash avatar May 10 '22 14:05 chibash

Thank you.

Sorry, I was referring to the latest release (rel_3_28_0_ga), and did not notice, that java.rmi has been already removed from Inner.java in the development branch. About the rest of the files: I listed all tests which currently can not be built with jdk17 because of java.rmi. Among them can be some internal dependencies.

zmiklank avatar May 10 '22 15:05 zmiklank

OK, I'll check them. By the way, I removed java.rmi from Inner.java today. So it's not your fault that you didn't notice that.

chibash avatar May 10 '22 16:05 chibash