attic icon indicating copy to clipboard operation
attic copied to clipboard

Tiny fixes: printf error messages and gitignore

Open sourcejedi opened this issue 10 years ago • 4 comments

Two tiny fixes, please merge :).

hashindex: Fix printf size specifiers in error messages gitignore: all cython generated files

sourcejedi avatar Aug 11 '15 21:08 sourcejedi

isn't %ju format and casting all these values to (uintmax_t) a more general solution?

ThomasWaldmann avatar Aug 11 '15 23:08 ThomasWaldmann

This' a bit less noisy and should work on Windows :).

I saw elsewhere Windows isn't supported. So"%j" (as in borg) is fine, and I agree uintmax is nice and explicit.

sourcejedi avatar Aug 12 '15 08:08 sourcejedi

@sourcejedi is there a problem with %j and Windows? Or Cygwin?

ThomasWaldmann avatar Aug 12 '15 10:08 ThomasWaldmann

It's a problem with native Windows. http://stackoverflow.com/a/22537979/799204

Apparently Cygwin is a whole 'nother library, so if you're using that then I don't know. I'd like to think it supports a 15-year old standard which has no fully-portable alternative :).

sourcejedi avatar Aug 12 '15 10:08 sourcejedi