covector icon indicating copy to clipboard operation
covector copied to clipboard

comments in Cargo.toml being purged

Open nothingismagick opened this issue 4 years ago • 3 comments

When running covector, it seems that comments in toml files are being pruned.

nothingismagick avatar Apr 19 '21 09:04 nothingismagick

This is an issue upstream in https://github.com/tauri-apps/tauri-toml. We should probably confirm that the fixes there have been addressed in the original https://github.com/iarna/iarna-toml and switch back to that if appropriate. (tauri-toml was forked to add support for inline objects which Rust/cargo allows as an option when specifying a dependency version.)

/cc @lucasfernog, have you looked into it?

jbolda avatar Apr 20 '21 16:04 jbolda

Considering if we can address this via #236.

jbolda avatar Apr 10 '22 16:04 jbolda

Just checked iarna-toml and unfortunately this has not been resolved upstream yet https://github.com/iarna/iarna-toml/issues/42.

I think we shouldn't wait for upstream and instead build a NAPI module using napi-rs that delegates the work to toml-edit crate which preserves the comments. I can help setting this up if approved.

amrbashir avatar Jan 16 '23 22:01 amrbashir

Closed by #303 and published in #300.

jbolda avatar Jun 06 '24 02:06 jbolda