gremlin-javascript icon indicating copy to clipboard operation
gremlin-javascript copied to clipboard

Allow user to close the connection

Open brianfoody opened this issue 8 years ago • 2 comments

I run this in an AWS lambda environment and need the ability to end the connection. It's appears to be missing so I have added it to WebSocketGremlinConnection.js.

brianfoody avatar Jul 14 '17 12:07 brianfoody

Thanks, on my phone right now - I will review tomorrow.

On Fri, 14 Jul 2017 at 14:33, Brian [email protected] wrote:

I run this in an AWS lambda environment and need the ability to end the connection. It's appears to be missing so I have added it to WebSocketGremlinConnection.js.

You can view, comment on, or merge this pull request online at:

https://github.com/jbmusso/gremlin-javascript/pull/81 Commit Summary

  • Add ability to terminate connection
  • Add ability to terminate connection
  • Delete .DS_Store

File Changes

Patch Links:

  • https://github.com/jbmusso/gremlin-javascript/pull/81.patch
  • https://github.com/jbmusso/gremlin-javascript/pull/81.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jbmusso/gremlin-javascript/pull/81, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMa1AyapXX_Bjsc65t02c2TdRXW6iWYks5sN2AFgaJpZM4OYMsv .

jbmusso avatar Jul 15 '17 17:07 jbmusso

Hey @jbmusso . Any chance of merging this and releasing a new npm version?

brianfoody avatar Aug 29 '17 13:08 brianfoody