Jeremy Maitin-Shepard
Jeremy Maitin-Shepard
Yes, I did just cast it to `PyObject*`: https://github.com/google/tensorstore/blob/24053fc2492ea958109ade321bdc8456688167f6/python/tensorstore/dim_expression.cc#L350
I don't believe there is any built-in support in pybind11 for defining a metaclass --- instead you have to use the Python C API directly to define the metaclass, as...
The bf_getbuffer handler installed by pybind11 just calls the user-defined function without catching and translating any exceptions. https://github.com/pybind/pybind11/blob/f791dc8648e1f6ec33f402d679b6b116a76d4e1b/include/pybind11/detail/class.h#L551 I have seen quite a few cases in pybind11 where c++ exceptions...
It would be nice to factor out the exception translation logic from `cpp_function` so that it can be used in other places within pybind11, such as here, and also by...
It seems you have created bazeliskisk, implemented in posix shell script. But what is the benefit of this bazeliskisk --- if you want to depend on a posix shell and...
Only x86_64, not arm platforms. And I wouldn't be too keen on checking in a bazelisk binary into my repositories. In any case, the Python version seems to be remaining...
I think this is sorely-needed functionality. Can you please write some documentation of the data format and metadata, so that I don't have to infer it from the code?
Taking a quick look at the code, I see that there isn't much to do the data format --- you add a `shards` key to the metadata and the shard...
I would also suggest supporting missing chunks within a shard.
Another thing to consider is putting the shard index in a separate file/key, and allow it to specify the key for individual chunks. That way you have some flexibility in...