Jeremy Maitin-Shepard

You could try just using the autodoc_pydantic extension, though it is likely our Python apigen extension will need some changes to work with it.

> > ``` > > nox > mypy > > sphinx_immaterial/search.py:89: error: Unsupported left operand type for / > > ("str") [operator] > > output_path = app.outdir / "search" /...

> > I'm having trouble with `npm run build`. I'm getting a "Illegal characters in path" error from rimraf: > > ``` > > npm run build > > >...

> I hope you don't mind if I push some commits to your branch. I won't force push anything, so you keep squashing the history as you see fit. Yes...

I noticed you fixed some lint issues in the search plugin (which I copied unmodified from upstream except for replacing mkdocs with mkdocs_compat) --- unless they are necessary bug fixes...

The icon-related error was actually due to `material/search.svg` not being a valid icon path. The extra error was due to my search integration not aborting if an error has already...

The `_TocVisitor` only has access to what is extracted from `sphinx.environment.adapters.toctree.TocTree`. I think you can access all of the doctrees from the builder, though, and from there extract the metadata...

To be clear we could support specifying the icon in the metadata, and still use our inline icon implementation for it.

Bumping dependencies is fine in general, the one tricky thing is that we have to be careful about cssnano/postcss-related deps because newer versions result in OOM (also applies to upstream...

> Honestly, this works well enough for me as it is now. > > I'm going to focus on the `feat: upstream` issues though. > > I haven't fully wrapped...