whitebox-tools icon indicating copy to clipboard operation
whitebox-tools copied to clipboard

compress_raster not working in v2.0.0

Open cefect opened this issue 2 years ago • 5 comments

Firstly, thank you for the excellent toolbox.

I just migrated from v1.4.0 to v2.0.0 and am now unable to generate uncompressed rasters using the BreachDepressionsLeastCost tool (I did not test other tools). I tried using the --compress_raster='False' flag and modifying the settings.json to "compress_rasters": false. Both still produce a raster with 'DEFLATE' compression.

Using whitebox_tools.exe from command line on Windows 10.

cefect avatar Jan 14 '22 16:01 cefect

I believe --compress_rasters is just a flag, no = or value needed. If you don't want the result compressed, then you don't add the flag.

brownag avatar Mar 10 '22 01:03 brownag

Hi @cefect, Thank you for raising this issue. We have addressed this issue and a fix has been implemented. It will be available in next open core release of WhiteboxTools. We are aiming for the end of April or early May. I will keep the issue open until it is fixed. See issue #233. If you require the fixed functionality, you can download and compile the source code.

Afrancioni avatar Mar 25 '22 18:03 Afrancioni

Just installed v2.1.0 and this still isn't fixed.

@brownag, omitting the flag still returns a result with DEFLATE compression

cefect avatar Oct 17 '22 09:10 cefect

@cefect --compress_rasters=FALSE seems to work for me on 2.1.0. I think I was mistaken that this can be used as a flag on more recent versions of WBT. The = and value are necessary, and in some cases the default may be TRUE?

If you are not using the --compress_rasters=FALSE, perhaps you have a settings.json file with it still set to TRUE in your working directory?

brownag avatar Oct 17 '22 14:10 brownag

@cefect For what it is worth, I made the same (incorrect) suggestion on this issue (https://github.com/jblindsay/whitebox-tools/issues/233) where @jblindsay responded with some more details

the --compress_rasters flag now does take a parameter value, meaning that Peter's --compress_rasters=False notation is the correct way to tell WBT not to compress rasters. Well, almost, Peter the issue that you had was that the actual flag name is --compress_rasters and not --compress_raster. This is actually my fault because the user manual had this incorrect, which is likely where you got it from. I have modified WBT to accept both compress_raster and compress_rasters now.

brownag avatar Oct 17 '22 15:10 brownag