Results 207 comments of Jasper

Apologies for not getting to this earlier, the recent comments bumped it back up my inbox though. I'd like to understand the reason for replacing the dependency. The MPL 2.0...

OK, if `x509-cert` is higher quality / has a smaller footprint then that seems a perfectly decent reason for the change. I see @brooksmtownsend mentioned that `x509-certificate`'s MPL 2.0 license...

Just for clarity, we already support multiple `rustls` crypto backends, and don't force any particular one to be chosen (except in tests where we have to pick one to run...

@aumetra I'm unable to re-open this as the source repository has been deleted — are you able to reinstate the source repository (or file a new PR if that's not...

I think this should resolve it: #82 Jicofo will need updating too: https://github.com/jitsi/jicofo/blob/master/src/main/kotlin/org/jitsi/jicofo/conference/source/Source.kt#L44

It doesn't seem to care about the namespace: https://github.com/jitsi/lib-jitsi-meet/blob/e1ca2f5a7b74ca2443f6cb4948f5e53b78aee1c6/modules/sdp/SDP.js#L759 It also produces ``s in the correct namespace in the other direction.

Opened https://github.com/jitsi/jicofo/pull/961 for the Jicofo part.

I can't find any use of `ParameterPacketExtension` or `SourcePacketExtension` in Jigasi, even though it seems like it should be used? It's used in JVB: https://github.com/jitsi/jitsi-videobridge/blob/e8f546396f37813cf42d4b4e28e39dd340d7caeb/jvb/src/main/kotlin/org/jitsi/videobridge/colibri2/Colibri2ConferenceHandler.kt#L124 I'll prepare a PR for...

@bgrozev I don't really need the value of the parameter, but the incorrect namespace causes the whole Jingle stanza to fail to parse, forcing us to use a fork of...

What's the MSRV of this crate?