dotfiles icon indicating copy to clipboard operation
dotfiles copied to clipboard

Feature/Bug: -f clobbers

Open xf3rno opened this issue 4 years ago • 2 comments

I finally attempted to include ~/.local/... in my dotfiles set, and as a result, lost the entire contents of the folder when running dotfiles -f -s. I realize -f is -f, but I'd expect files not present in my dotfiles repo, but present in ~/.local, to remain there.

Is this intended behavior?

It could be avoided by detecting the folder exists, not symlinking it, and instead of linking the new files individually.

The -f flag help message states "overwrite colliding dotfiles"; there was no collision in this instance, except for the top-level folder.

If not intended, the folders should be merged together.

xf3rno avatar Dec 22 '20 20:12 xf3rno

Hey Cris, this is not intended behavior, I'm sorry. Thanks for your report, I'll try to take a look at this as soon as I can and get an update pushed - please bare with me, this year has been completely insane. It's quite likely that the version in git resolves this, but a few other things have changed in that code as well. If you have time and are interested in testing it, I would greatly appreciate it.

jbernard avatar Dec 30 '20 20:12 jbernard

Alright, I've noticed the discrepancy between the pip version & the latest master from some time ago. I will test the new version in my free time, will update if I see the clobber occur again.

xf3rno avatar Jan 07 '21 07:01 xf3rno