dotfiles icon indicating copy to clipboard operation
dotfiles copied to clipboard

No more Windows support since 48e781

Open garyo opened this issue 7 years ago • 4 comments

I've been using this for some years on Windows, Mac and Linux to manage my dotfiles, and just recently updated to latest version. I notice you removed Windows symlink support in 48e781, which I added a very long time ago. Just wondering if that was intentional.

garyo avatar Jul 23 '18 14:07 garyo

I've been using this for some years on Windows, Mac and Linux to manage my dotfiles, and just recently updated to latest version. I notice you removed Windows symlink support in 48e781, which I added a very long time ago. Just wondering if that was intentional.

Sorry about that, I was thinking that python3 resolved this and that compatibility code was no longer necessary, but I could certainly be wrong about that. It was not intentional to cause a regression. I'll try to post an update soon, within the week hopefully.

-- Jon

jbernard avatar Jul 23 '18 16:07 jbernard

Some time ago I switched to pylib, which simplified the code substantially and I thought windows was supported as well. It's in maintenance mode now and python's pathlib appears to be the standard over os.path - and has nearly a one-to-one mapping of methods from pylib. There's a compatibility module pathlib2 for pre python 3.4 which should allow the functionality to be realized by any supported version of python (including 2.7). So my plan is to migrate to pathlib. Do you see any problems with this approach? Does pathlib work reliably on your platform in general?

jbernard avatar Sep 22 '18 19:09 jbernard

@garyo @jbernard : was there a resolution to this?

Does dotfiles work within a Windows 10, python 3 environment?

WaterSibilantFalling avatar Apr 15 '19 03:04 WaterSibilantFalling

It should - I’m only using one package (click) for the CLI, everything else is in the standard library. Specifically pathlib which claims to support Windows without issue, though how true remains untested in this context. Either way, if there are issues on Windows I will try to fix them, I do care about that platform and I consider failures there to be a bug.

jbernard avatar Apr 15 '19 20:04 jbernard