sms-backup-plus icon indicating copy to clipboard operation
sms-backup-plus copied to clipboard

MMS oddities

Open 2Fast08 opened this issue 9 years ago • 10 comments

Most of my MMS that get backed up show up in Gmail as a single thread to myself, and thus, not included in the proper conversation thread in gmail.

Samsung Galaxy S7

2Fast08 avatar Jul 24 '16 04:07 2Fast08

Same for me. I'm not using a lot MMS but the issue has started from May 26th (X-smssync-version: 1556) for me.

Edit.: I've got more infos, before I had this issue I'm using the X-smssync-version: 1554

psykauze avatar Jul 25 '16 14:07 psykauze

Looks like it is from commit 7884ec6. Need confirm.

Here a sample: (I've replaced my name, phone number and email by John Doe ones. The "references" line is also not correct "xxx.3335" instead of "xxx.3315") MMS.txt

psykauze avatar Jul 25 '16 14:07 psykauze

I think this part of "HeaderGenerator.java" is broken:

private void setSmsHeaders(Message message, Map<String,String> msgMap) throws MessagingException {
    message.setHeader(Headers.ID, msgMap.get(Telephony.BaseMmsColumns._ID));    // Why use a MMS class for SMS header ? Also, I don't find an explanation for "_ID".
    message.setHeader(Headers.TYPE, msgMap.get(Telephony.TextBasedSmsColumns.TYPE));
    message.setHeader(Headers.DATE, msgMap.get(Telephony.TextBasedSmsColumns.DATE));
    message.setHeader(Headers.THREAD_ID, msgMap.get(Telephony.TextBasedSmsColumns.THREAD_ID));
    message.setHeader(Headers.READ, msgMap.get(Telephony.TextBasedSmsColumns.READ));
    message.setHeader(Headers.STATUS, msgMap.get(Telephony.TextBasedSmsColumns.STATUS));
    message.setHeader(Headers.PROTOCOL, msgMap.get(Telephony.TextBasedSmsColumns.PROTOCOL));
    message.setHeader(Headers.SERVICE_CENTER, msgMap.get(Telephony.TextBasedSmsColumns.SERVICE_CENTER));
}

'

private void setMmsHeaders(Message message, Map<String,String> msgMap) throws MessagingException {
    message.setHeader(Headers.ID, msgMap.get(Telephony.BaseMmsColumns._ID));    // I don't know what does "_ID" mean.
    message.setHeader(Headers.TYPE, msgMap.get(Telephony.BaseMmsColumns.MESSAGE_TYPE));
    message.setHeader(Headers.DATE, msgMap.get(Telephony.BaseMmsColumns.DATE));
    message.setHeader(Headers.THREAD_ID, msgMap.get(Telephony.BaseMmsColumns.THREAD_ID));
    message.setHeader(Headers.READ, msgMap.get(Telephony.BaseMmsColumns.READ));
}

`

psykauze avatar Jul 26 '16 09:07 psykauze

Same problem here - MMS are shown in gmail as emails from myself.

SMS Backup+ 1.5.10 Android 6.0.1 Samsung Note5

computerdude95 avatar Sep 28 '16 17:09 computerdude95

I just add some precision to the faulty MMS about the joined picture. See my link just above.

mdes avatar Oct 30 '16 09:10 mdes

It's been 3 months and the issue still exists, are we going to get an update on this or not.

2Fast08 avatar Oct 30 '16 14:10 2Fast08

@2Fast08 @mdes Can you post some headers from backed up MMS emails (anonymized) ?

jberkel avatar Nov 08 '16 14:11 jberkel

I would if I knew how.

2Fast08 avatar Nov 08 '16 18:11 2Fast08

@2Fast08 don't worry, got some already.

jberkel avatar Nov 08 '16 21:11 jberkel

I would really love to see a fix for this as well. For me, I see normal conversation threads in GMail for almost all messages; but whenever I reply on my phone and attach a picture, that picture message gets pulled out of the correct GMail thread. Instead, every picture I've sent to anyone at all shows up as a single GMail thread of me talking to myself. Looking at the backups, I have no way of telling who I sent a given picture to; and when reviewing individual threads, the conversations are disjointed because every MMS message I sent is missing.

In the past, this behavior would occur for MMS messages that were part of a group conversation. I forgave that behavior because I could understand the difficulty of properly sorting group messages. But now, it happens for every MMS message I send, even MMS messages to a single individual. (Received MMS messages do not fall prey to this problem.)

This used to work properly in the past, but some change has broken it. Looking at the backed-up messages from three phones in my family, it seems that all of our phones received the update with the breaking change sometime around Feb 1, 2016.

dtuma avatar Jan 03 '17 05:01 dtuma