Joel Berger
Joel Berger
Oh, and that gzip is imported from Mojo::Util, so even better, check here: https://github.com/mojolicious/mojo/blob/main/lib/Mojo/Util.pm#L164
And now that I've reread the OP, both of those were suggestions ... sigh, one day I'll learn to read back. IMO, I'd check it at Mojo::Util::gzip.
> I'm not sure what the right solution is but I'll note that attempting to connect to localhost breaks more often. We might first check that either localhost resolves or...
Test failure for me: ``` t/mojo/websocket_proxy_tls.t ............... 1/? # Failed test 'right content' # at t/mojo/websocket_proxy_tls.t line 126. # got: '' # expected: 'https://localhost:56835/proxy' # Failed test 'right content' #...
More info: ``` % openssl version LibreSSL 3.3.6 ``` ``` % perl -Ilib script/mojo version CORE Perl (v5.34.0, darwin) Mojolicious (9.32, Waffle) OPTIONAL Cpanel::JSON::XS 4.09+ (4.29) EV 4.32+ (n/a) IO::Socket::Socks...
re-testing: ``` mojo % TEST_ALL=1 prove -lr t t/mojo/asset.t ............................. ok t/mojo/base.t .............................. ok t/mojo/bytestream.t ........................ ok t/mojo/cache.t ............................. ok t/mojo/cgi.t ............................... ok t/mojo/collection.t ........................ ok t/mojo/content.t ........................... ok t/mojo/cookie.t...
But actually now I'm getting the same test failures both in the PR branch and main
While I don't generally feel we need to micro-optimize module loading across the stack, I guess I can see that there are a few dependencies in Mojo::Util that could be...
In general that would be true, however, at least Pod::Usage would rarely need to be early-loaded for preforking. I guess I could argue GetOpt::Long either way, though in a non-webapp/Mojo::UserAgent...
I'm out of town and reading on my phone so I'm not going to do a full review, but I think I agree with @kraih there are things in there...