jvector icon indicating copy to clipboard operation
jvector copied to clipboard

Clean up to index builder api

Open tjake opened this issue 1 year ago • 1 comments

The GraphIndexBuilder api can be used in two ways: for live indexing or bulk indexing.

We should enforce checks in the api such that users don't call it incorrectly or just keep the existing builder as internal and publish two public builder apis for IncrementalBuilder and BulkBuilder.

An example of wrong usage is calling addGraphNode directly, followed by build

tjake avatar Oct 11 '23 14:10 tjake

Calling build() multiple times is also bad. Should we just have build() check to make sure the graph is empty and throw if not?

jbellis avatar Oct 20 '23 13:10 jbellis