Jonathan Ellis
Jonathan Ellis
I saw the same behavior on two different machines, fwiw. One was 18.2.0 until I upgraded it. (Behavior did not change.)
1. Yes 2. rebuild history does not help, either immediately or after re-attempting the deletes
I think I figured it out. ctrl-r interface deduplicates the command history, but ctrl-o ctrl-d only deletes one of the instances. (the most recent?) `atuin history list` shows instances of...
Suggested fix: - Print "deleted [command] [timestamp]" to show that it's making progress (and to remind the user that there's deduplication going on) - Don't remove the command from the...
Ready for final review. One hiccup that I'm not sure how to solve: AnnIndexScan overestimates its cost: ``` double scanCost = annSearchCost(estimatedNodes, expectedKeysInt); ``` This should be ``` double scanCost...
I think we have a similar issue in estimateAnnSortCost, we just happen to be lucky there and expectedKeysInt=limit.
okay, the ann planning is working now with everything i've thrown at it, and I've merged from main. will let CI run next. one last issue: PlanTest.intersectionWithEmpty is failing because...
test failures are addressed.
``` // VSTODO is it worth optimizing this for one-to-many case as well? private class GenericRowIdsView implements RowIdsView ``` testing says the answer is yes, this is one of the...
I think this is ready to commit. Failure in VectorTypeTest.tracingTest was legit, fixed. Failures in VectorSiftSmallTest, TinySegmentQueryWriteLifecycleTest, QueryWriteLifecycleTest do not reproduce locally. The other failing tests are either definitely broken...