yaml-cpp icon indicating copy to clipboard operation
yaml-cpp copied to clipboard

Published 20 hours ago • verified publisher icon jbeder

Export only YAML_CPP_API-tagged symbols on Linux.

Open RAOF opened this issue 6 years ago • 3 comments

Mark classes tagged with YAML_CPP_API with visibility("default"), to explicitly export them, and then hide everything else via -fvisibility=hidden.

This reduces the number of exported symbols by more than 50%, which has a small application start-up time and memory useage benefit. It also makes it more feasible to audit the set of exported symbols in automated ABI compatibility systems.

RAOF avatar Nov 23 '18 04:11 RAOF

In addition to running the unit-tests I've also built all of the packages in Ubuntu which depend on yaml-cpp against the it. All of them (at least the ones which don't fail for other reasons, like not using C++11) build fine against this, so those symbols are really unused.

RAOF avatar Nov 23 '18 04:11 RAOF

@RAOF For Windows the classes shouldn't be tagged with YAML_CPP_API but the public methods. Will that conflict with Linux in any way? Which is something I intend to submit soon.

Zingam avatar Feb 13 '19 23:02 Zingam

#958 seems related and especially I think letting cmake handle this is good idea. https://github.com/jbeder/yaml-cpp/pull/958#issuecomment-759639237

vmiheer avatar Jan 13 '21 18:01 vmiheer