yaml-cpp icon indicating copy to clipboard operation
yaml-cpp copied to clipboard

CMake: hide all symbols by default in shared lib

Open SpaceIm opened this issue 2 years ago • 1 comments

Hide private symbols irrespective of compiler when yaml-cpp shared is built with CMake. This PR is similar to https://github.com/jbeder/yaml-cpp/pull/984, but it does not remove dll.h (which was the reason why it has been reverted in https://github.com/jbeder/yaml-cpp/pull/1038). So it doesn't break users not relying on CMake to build yaml-cpp.

Also simplify dll.h, which had lot of dead code, and weird logic for entering in declspec branch (actually it's windows specific, so _WIN32 is fine).

SpaceIm avatar Oct 30 '23 09:10 SpaceIm

Has conflicts now.

nigels-com avatar Apr 25 '24 03:04 nigels-com