Jonathan Bluett-Duncan

Implement a topological ordering algorithm

14

I was implementing a [topological sorting](https://en.wikipedia.org/wiki/Topological_sorting) prototype method yesterday out of curiosity, and I'm sharing it today in this PR to start a discussion about whether topological sorting has a...

Consider migrating from JUnit 3/4 to JUnit Jupiter & JUnit 5

1

If we decide this is worth doing, we will have to take the following things into account. 1. We should prefer JUnit Jupiter API's [`assertThrows`](http://junit.org/junit5/docs/current/api/org/junit/jupiter/api/Assertions.html#assertThrows-java.lang.Class-org.junit.jupiter.api.function.Executable-) over the `try..fail..catch` idiom 2....

Consider allowing `MutableCTree#putEdge` to indirectly change the root of the tree

10

Currently, if one is given a `CTree` like the following, ```java MutableCTree tree = TreeBuilder.builder().build(); tree.putEdge("b", "c"); ``` then if one tries to add the following edge, ```java tree.putEdge("a", "b");...

What to do with "internal implementation detail" classes and other "utils" classes?

2

@jrtom Currently, there are a number of classes in JUNG which seem to be either internal implementation details which nonetheless have the `public` modifier, meaning JUNG users can use them...

Bug: Throws exception in Android project with `localTest` and `local` build types

4

**Build scan link** https://scans.gradle.com/s/iz5db3a77i22g **Plugin version** 1.15.0 **Gradle version** 7.4.2 **(Optional) Android Gradle Plugin (AGP) version** 4.2.2 **Describe the bug** When importing this plugin into an Android project with two...

Confusion on contents of saved `Graph.adjacentNodes(n)` if `n` is eventually removed

6

I recently found myself writing this code. ```java MutableGraph graph = GraphBuilder.undirected().build(); graph.addNode(1); Set adjacentNodesView = graph.adjacentNodes(1); System.out.println(graph.edges()); // [] System.out.println(adjacentNodesView); // [] System.out.println(graph.adjacentNodes(1)); // [] graph.putEdge(1, 2); System.out.println(graph.edges()); //...

graph: Use generics and other Go 1.18 features in the leaves and other packages

23

This PR is a follow-up to https://github.com/gonum/gonum/pull/1735, which aimed to generify some of the leaf dependencies of the `graph` package in preparation for https://github.com/gonum/gonum/issues/617 to make migrating `graph`'s API to...

JUnit 5: Support `@Nested` classes

5

If one runs an `@TestParameterInjectorTest` test method inside an inner class annotated with JUnit 5's `@Nested` annotation, it throws the following stack trace. **Example** ```java import com.google.testing.junit.testparameterinjector.junit5.TestParameterInjectorTest; import com.google.testing.junit.testparameterinjector.junit5.TestParameters; import...

Formatting of lambda followed by `.asSequence()` is a bit strange

3

I recently wrote some code like in the dropdown below, which uses `ShortestPath` from [github.com/google/mug](https://github.com/google/mug), and which I was hoping ktfmt would leave as-is: Original code, expected to be left...

Incompatible with the configuration cache

14

I'm using rewrite-gradle-plugin's `rewriteDryRun` in my [project](https://github.com/jbduncan/guava-graph-utils) as a task that gets run everytime `./gradle check` is run, but when I enable the [configuration cache](https://docs.gradle.org/8.3/userguide/configuration_cache.html), it prints some errors and...