Jonathan Bluett-Duncan
Jonathan Bluett-Duncan
Here are the benchmarks. I'm not sure what to make of them. WDYT? Benchmarks ``` goos: darwin goarch: arm64 pkg: gonum.org/v1/gonum/graph/coloring │ bench.old │ bench.new │ │ sec/op │ sec/op...
Sorry for the long delay in getting back to you, @kortschak! I finally found the time to get back to this and address all your review comments, so I'm ready...
How interesting, the AppVeyor build is failing because: ``` go: download go1.22 for windows/amd64: toolchain not available ``` But given how you updated to Go 1.23 in [4cb1c6f](https://github.com/gonum/gonum/commit/4cb1c6f4a863dd4bde148d9b8736b7d69af4b75b) a few...
@onsi I'm interested in seeing this PR being merged in, but I see that it is suffering from merge conflicts and I'm not sure if the author is around to...
@rminnich @binjip978, I see that @binjip978 approved things a week ago, so I was wondering if there's anything else I need to do before this can be merged in? I'm...
Woo! Really happy to see this merged in, so thank you for reviewing this and being so receptive, @binjip978 and @rminnich. :)
That sounds great @jrtom! Many thanks for your response. I realise trees are probably not going to appear in common.graph any time soon, but nonetheless it's exciting to hear what...
Also, thanks for fixing the typo in the issue title. :)
Hi @lowasser. I'm struggling to explain my use case very well and succintly, so I want to apologise in advance if you struggle with the wall-of-text below and/or if I've...
@jrtom and @lowasser, thank you both very much for your constructive feedback. @jrtom, I understand your argument for the toString() representation for trees, and I completely agree! I only meant...