cordova-plugin-video-editor icon indicating copy to clipboard operation
cordova-plugin-video-editor copied to clipboard

Consider adding new features: Render status, multiple files, cancel render

Open kmturley opened this issue 9 years ago • 6 comments

I've been using the plugin as a base and added some new features, unfortunately I had to make the changes pretty quickly and only supporting Android. So I didn't create a pull request. I've copied the code in here because it could help extend your plugin:

VideoEditor.js

  • onprogress callback function to show render progress
  • killVideoProcessor function to stop render halfway if user cancels https://gist.github.com/kmturley/164fe4c659b3b06b8f96

VideoEditor.java

  • startTime endTime params
  • support for intro, middle and outro video files
  • support for overlay png on middle video file
  • on render progress shell output passed to JS https://gist.github.com/kmturley/5cc2b481af1a6169f80e

FfmpegController.java

  • ffmpeg command support for start time end time and overlay
  • ffmpeg preset ultrafast and quality 100%
  • ffmpeg commands for mp4 and aac encoding https://gist.github.com/kmturley/695bd1612c2ef47d42f6

I was planning on updating my own version with these features, but haven't go around to doing that yet: https://github.com/kmturley/cordova-plugin-video-editor

Feel free to copy the code you need to enhance your project!

kmturley avatar Nov 10 '15 16:11 kmturley

Thanks, I plan to integrate some of these features.

rossmartin avatar Nov 11 '15 04:11 rossmartin

awesome!

kmturley avatar Nov 11 '15 13:11 kmturley

@kmturley Thanks for the input and code! We always love community contributions. <3

jbavari avatar Nov 11 '15 18:11 jbavari

Awesome code. Could use some of this functionality in the near future, but I can wait for further updates to this project. @rossmartin nicely done with the standalone trimming feature. Looking forward to new features and the future of this plugin.

cameronws avatar Nov 12 '15 21:11 cameronws

+1 for cancel rendering. Highly needed.

shahin8r avatar May 28 '16 20:05 shahin8r

2020 still no cancel render for cordova-plugin-video-editor yet :( any solution for this? I'm using Ionic 5.

Toan2671997 avatar Dec 25 '20 16:12 Toan2671997