Jonathan Barnoud
Jonathan Barnoud
We cannot remove kwargs here, otherwise third party code will break every time we change the signature.
I mean that for AnalysisBase. The other classes can loose the kwarg.
Hi @fortune-max. Thank you for opening this pull request. It is difficult to review, though, because it lacks some context. Can you edit your pull request message to follow the...
I'd like pyright to be included as well, but it is fairly low priority.
I'll have a look on Monday :)
I would suggest you run mypy on the tests, this is where the objects get used and therefore where you get to evaluate your annotations. Also, at least when running...
As long as `npt.NDArray` does not provide ways of specifying shapes, I would just roll back to `np.ndarray`. I did consider stub files but I am concerned new contributors will...
@aya9aladdin I recommend that you push your changes often. Do not wait for the code to be finished. By pushing often, we get to see your progress, we get to...
You already have a pull request, no need to open another one. Instead, update this pull request by pushing your new commits.
One more thing. Please give more explicit titles to your commits. When I receive an email notification about a commit entitled `Update DefaultGuesser.py` it is much less useful than if...