jbang icon indicating copy to clipboard operation
jbang copied to clipboard

Published 20 hours ago • verified publisher icon jbangdev

refactor: merge alias attributes

Open quintesse opened this issue 10 months ago • 2 comments

When one alias refers to another we now merge the attributes of the two aliases (when dealing with lists and maps, in the case of simple values the "parent" alias overrides the "child" alias).

See #1910

quintesse avatar Jan 23 '25 17:01 quintesse

I think this might be right but not fully sure ... it does seem to be breaking behavior but maybe what we had before was worse.

got some examples of what we solve and what we break?

maxandersen avatar Jan 25 '25 04:01 maxandersen

It's difficult, I'm not sure how many examples we have "in the wild" of aliases referring to other aliases. And then they'd both need to have arguments (or other options) defined. Only in those cases the behaviour has been changed.

Thing is, I just tried it and although the PR does what it says it does, it unfortunately doesn't actually fix the problem mentioned in #1910 :-(

quintesse avatar Jan 25 '25 21:01 quintesse