jbang icon indicating copy to clipboard operation
jbang copied to clipboard

Allow JREs

Open quintesse opened this issue 2 years ago • 3 comments

This PR allows JREs to be used by Jbang. This should make it possible to use much of Jbang's functionality without having a JDK installed. Except for the most important of course, which is being able to build.

But this will let you for example list the available JDKs and decide which one you want to install, instead of Jbang first installing a default version, like 11, before it will allow you do do anything else.

quintesse avatar Jan 17 '23 13:01 quintesse

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage :thumbsup:

Coverage data is based on head (cff5b07) compared to base (006959a). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1542   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        121     121           
  Lines       7409    7428   +19     
  Branches    1199    1203    +4     
=====================================
- Misses      7409    7428   +19     
Flag Coverage Δ
Linux 0.00% <0.00%> (ø)
Windows 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/dev/jbang/cli/App.java 0.00% <0.00%> (ø)
src/main/java/dev/jbang/cli/Info.java 0.00% <0.00%> (ø)
src/main/java/dev/jbang/cli/Jdk.java 0.00% <0.00%> (ø)
.../java/dev/jbang/dependencies/ModularClassPath.java 0.00% <0.00%> (ø)
src/main/java/dev/jbang/net/JdkManager.java 0.00% <0.00%> (ø)
src/main/java/dev/jbang/net/JdkProvider.java 0.00% <0.00%> (ø)
...a/dev/jbang/net/jdkproviders/JBangJdkProvider.java 0.00% <0.00%> (ø)
...va/dev/jbang/net/jdkproviders/PathJdkProvider.java 0.00% <0.00%> (ø)
src/main/java/dev/jbang/source/AppBuilder.java 0.00% <0.00%> (ø)
...java/dev/jbang/source/buildsteps/JarBuildStep.java 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 17 '23 13:01 codecov[bot]

rebase?

maxandersen avatar Mar 17 '23 23:03 maxandersen

Still not marked as ready :-) I'm just not 100% happy with it, even though it's a pretty nice feature.

quintesse avatar Mar 18 '23 23:03 quintesse