jbang-action icon indicating copy to clipboard operation
jbang-action copied to clipboard

Support Java 17 LTE

Open quintesse opened this issue 3 years ago • 5 comments

We should probably have a version of the action that supports Java 17 now that it's the latest long term support release.

This probably means coming up with a new tagging scheme, something like jbangver-javaver, eg 0.83.0-11, 0.83.1-17 and a tag 0.83.1 that refers to one of those, for now it should probably remain 11.

quintesse avatar Nov 25 '21 10:11 quintesse

Now I use https://gist.github.com/maxandersen/f077f1d356c42eeb395a8811d6152f3a to build Hello.java Docker image with Java 17. it's some slow to download JDK 17 by JBang. If you don't setup cache, and JBang will download JDK 17 every time when building image.

image

linux-china avatar Apr 29 '22 17:04 linux-china

+1 on finding way to build multiple versions per java and publish.

maxandersen avatar Apr 30 '22 07:04 maxandersen

Hi! We require JDK 21. As a workaround, we have checked out the repo and made this change to the Dockerfile and pushed the image to our own image registry:

FROM eclipse-temurin:21-jdk-alpine

As proposed earlier we also have chosen a suffix indicating the JRE flavor and release: jbang-action:v0.113.0-temurin21

Maybe something like this could be achieved with a GHA matrix based build, and keeping JDK 11 the default for backwards compatibility when no Java release suffix is present.

mbechto avatar Dec 05 '23 11:12 mbechto

I have start at https://github.com/jbangdev/jbang/pull/1654 but haven't had time to finish it.

Ps. In github actions I recommend using setup-jbang rather than the container image these days. It allows setting up specific java version with caching using setup-java.

maxandersen avatar Dec 05 '23 17:12 maxandersen

Just adding the link for easy reference: https://github.com/marketplace/actions/setup-jbang

quintesse avatar Dec 05 '23 19:12 quintesse