ember-legit-forms icon indicating copy to clipboard operation
ember-legit-forms copied to clipboard

Published 20 hours ago • verified publisher icon jbandura

Improvements RFC

Open jbandura opened this issue 8 years ago • 4 comments

  • [x] upgrade ember and ember-cli to the newest versions
  • [x] add test helpers for fillingIn inputs (both for acceptance and integration tests)
  • [x] add acceptance tests
  • [x] work on making creation of custom inputs easy
  • [ ] add support for inline forms (from TWBS)
  • [ ] implement radio input
  • [ ] implement checkbox input
  • [x] handle the submit action on form

jbandura avatar May 28 '16 15:05 jbandura

@jbandura Have you considered removing ember-get-helper from plugin dependencies? According to their documentation:

ember-get-helper has been included in Ember 2.0. Use of this package is deprecated and support for Ember 2.0 will not be maintained.

I think it would also be reasonable to update this plugin and use newest dependencies even though it could drop support for Ember 1.x.

Btw. ember-legit-forms 2.0.x sounds legit :D Don't you think?

michalsnik avatar Aug 25 '16 22:08 michalsnik

@snik the ember-get-helper will be removed in 2.0 (it's already gone in the master branch) :)

jbandura avatar Jan 01 '17 16:01 jbandura

@jbandura Sweet 👍

michalsnik avatar Jan 01 '17 17:01 michalsnik

Unfortunately, it looks like the version of ember-one-way-controls this relies on, 0.8.0, still relies on an older version ember-get-helper, v1.0.4, which I believe yields a this._super deprecation warning still.

Bumping ember-one-way-controls to 2.0 should do the trick, but I haven't tested it out myself.

edit: attaching pr #36

maxscott avatar Feb 07 '17 20:02 maxscott