Josh Bailey

Results 13 comments of Josh Bailey

I also ran into related issues/confusion on loading sub-states, but eventually got my engine working after ready @nathanhammond comment. Using `application-loading.hbs` within the engine, itself works. Although, following the guides,...

> declare your services in the dummy app? @Leooo @trentmwillis My app at work constantly runs into this too, and so far we've landed on this approach. One problem we...

@drummy2 PR #192 should have defaulted installations of `ember-cli-sass` to use dart-sass by default, removing the need for `node-sass`. This was released in `v8.0.1`.

@robclancy Interesting. I haven't noticed any slow down when I switched a large ember app from node-sass -> dart-sass. At least we have the `implementation` escape-hatch in this addon. Hopefully...

Making `dart-sass` the default started [here](https://github.com/aexmachina/ember-cli-sass/pull/186) and was completed [here](https://github.com/aexmachina/ember-cli-sass/pull/192), for reference. The motivation was based on the fact that `dart-sass` is the primary, default SASS implementation declared by the...

Having the same issue. After looking at the [initializer](https://github.com/adopted-ember-addons/ember-cli-ifa/blob/master/addon/initializers/asset-map.js) I believe the issue is due to properties on the AssetMap service are not being consistently set across environments. The initializer...

@crodriguez1a Seems like conditionally setting the `onclose` action is a side-effect of using the `show` attr to show/hide the modal. What if we slightly changed the implementation, where we instruct...

@crodriguez1a Seems like this is a bug in ember core -> https://github.com/emberjs/ember.js/issues/15322. The issue hasn't received any feedback yet, but I think it's safe to say this isn't due to...

@crodriguez1a Yeah I'll look into it, working on some test ATM. Weird bug...

@alexdiliberto What I've experienced by other addons is that focus handling, and a11y in general, is left to the consumer to implement. I'm not against supporting this though. Perhaps we...