webhook-discord icon indicating copy to clipboard operation
webhook-discord copied to clipboard

Rewrite to use Discord webhooks instead of Slack-compatible Discord webhooks

Open jb3 opened this issue 5 years ago • 6 comments

As said in the title, currently we use the /slack endpoint since when I created this library this is what I was most knowledgable with. We should now migrate this to use Discord webhook formatting.

jb3 avatar Apr 23 '20 22:04 jb3

What would be the best way to start this ? I assume we would use https://discordjs.guide/popular-topics/embeds.html#embed-preview

Exitare avatar Apr 23 '20 23:04 Exitare

Not necessarily, the Discord docs are sufficient for this.

jb3 avatar Apr 23 '20 23:04 jb3

https://discordapp.com/developers/docs/resources/webhook#create-webhook, this one?

Exitare avatar Apr 23 '20 23:04 Exitare

https://discordapp.com/developers/docs/resources/channel#embed-object this will be the most useful.

jb3 avatar Apr 23 '20 23:04 jb3

Does it make sense to rewrite the library if can use Discord.js and its WebhookClient. WebhookClient also supports working with the inner Discord.js MessageEmbed class.

Yes, the library will be less in size, but it seems to me that this is not a particularly weighty argument.

egorprnn avatar Nov 13 '20 09:11 egorprnn

I think it makes sense to rewrite it, yes.

This library serves as an independent way to work with webhooks without discord.js, it gets used and has thousands of downloads on NPM.

We should continue development of this library irrelevant of the external situation with webhook libraries on NPM.

jb3 avatar Nov 13 '20 10:11 jb3