jazz icon indicating copy to clipboard operation
jazz copied to clipboard

move declarations to separate file

Open naturallymitchell opened this issue 5 years ago • 3 comments

https://github.com/foundpatterns/torchbear/blob/fdb47a2150261c1869b39e364a90ac60d70f6d3f/src/lib.rs#L2-L48

would it be possible to move extern crate declarations to declarations.rs or better? we should be able to Split a module across several files , right?

naturallymitchell avatar Dec 11 '18 12:12 naturallymitchell

For now they can stay as is since moving them wont really solve anything and would likely break stuff. I do plan on moving torchbear to 2018 edition which would allow us to remove extern crate for the majority of them, though there is really no gain or loss from switching

dariusc93 avatar Dec 11 '18 20:12 dariusc93

With a switch to 2018 edition (https://github.com/foundpatterns/torchbear/issues/154), the extern crate will be optional unless a macro is going to be used then it would need to be included.

dariusc93 avatar Jan 10 '19 23:01 dariusc93

I'd still like to split lib.rs into organized submodules

naturallymitchell avatar Jun 24 '20 04:06 naturallymitchell