sorl-thumbnail
sorl-thumbnail copied to clipboard
Fixes #691 - Obsolete THUMBNAIL_KVSTORE
Codecov Report
Merging #692 (1069524) into master (f62c617) will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 73.75% 73.80% +0.04%
==========================================
Files 30 30
Lines 1688 1691 +3
==========================================
+ Hits 1245 1248 +3
Misses 443 443
Impacted Files | Coverage Δ | |
---|---|---|
sorl/thumbnail/kvstores/base.py | 95.00% <100.00%> (+0.20%) |
:arrow_up: |
sorl/thumbnail/kvstores/cached_db_kvstore.py | 93.47% <100.00%> (-0.14%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f62c617...1069524. Read the comment docs.
Please just wait a bit before reviewing this patch, there are some things I'd want to check before going forward.
Please just wait a bit before reviewing this patch, there are some things I'd want to check before going forward.
@claudep Convert this PR to draft? It's from 2022.
@claudep Django 3.x is no longer maintained, so we only have Django versions that supports Redis cache. Removing non-supported Django versions in https://github.com/jazzband/sorl-thumbnail/pull/754.
How I can help with this PR?
@claudep how about remove the support without deprecating and release major release with a breaking change 😉
I think we can release a 12.x version with the deprecation, and not so long after release a 13.x version with the removals.
@claudep may I merge this PR, it looks good to me.
Thanks for the review!