pip-tools icon indicating copy to clipboard operation
pip-tools copied to clipboard

Add compat modules for `tomllib` and `importlib.metadata`

Open chrysle opened this issue 1 year ago • 4 comments

The conditional backports increased, thus I added two compatibility modules.

Contributor checklist
  • [ ] Included tests for the changes.
  • [ ] PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • [x] Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • [ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

chrysle avatar Jun 26 '24 20:06 chrysle

Can you rebase this? The CI failures seem unrelated.

WhyNotHugo avatar Aug 14 '24 10:08 WhyNotHugo

The CI failures seem unrelated.

They are, but tests are also failing on main. We're struggling to fix them for quite a while now. #2106, which still awaits reponse, partly succeeds in doing that, but then there're still the broken Windows tests and I ~~hate Windows~~ feel unable to reproduce the failure.

chrysle avatar Aug 14 '24 11:08 chrysle

@chrysle I've responded there since.

webknjaz avatar Sep 05 '24 14:09 webknjaz

@chrysle the CI is green and more stable now :tada:

webknjaz avatar Dec 16 '24 04:12 webknjaz