pip-tools icon indicating copy to clipboard operation
pip-tools copied to clipboard

Remove duplicate PyPIRepository().finder.find_all_candidates cache

Open gschaffner opened this issue 2 years ago • 0 comments

Hi! I believe that PyPIRepository()._available_candidates_cache is redundant, as PackageFinder().find_all_candidates has been lru_cached since Pip 20.3 (https://github.com/pypa/pip/commit/1dd6d562789b06dc1508212505e32f36bd71d310).

Contributor checklist
  • [ ] Provided the tests for the changes.
  • [x] Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • [ ] Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • [ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

gschaffner avatar May 31 '22 00:05 gschaffner