jsonmodels icon indicating copy to clipboard operation
jsonmodels copied to clipboard

ListField: removed default `None` value for the `items_types` parameter.

Open avrahamshukron opened this issue 8 years ago • 4 comments

This will create more consistent code since item_types is required. Tests had to be modified a bit. Specifically tests which used Model class with circular reference to itself. It was easier to just extract the dummy class outside the function, in order to avoid import path hell.

This change breaks the current API, so if merged it should be into a new major version.

Fixes #96

avrahamshukron avatar Oct 09 '17 22:10 avrahamshukron

@avrahamshukron nice, and you are right - therefore lets make version 3 :) before that I need to release some small improvements to branch 2.x and then we will do all BC breaking stuff (this and regexes too)

beregond avatar Aug 07 '18 18:08 beregond

Sure, thanks! Please hold the release of 3.0 until the weekend, I might have some more small fixes to push.

avrahamshukron avatar Aug 07 '18 18:08 avrahamshukron

Ok, no problem

beregond avatar Aug 13 '18 05:08 beregond

I totally forgot about this... If it is still relevant you can absolutely merge this.

avrahamshukron avatar Oct 28 '18 19:10 avrahamshukron