icalevents icon indicating copy to clipboard operation
icalevents copied to clipboard

Update icalparser.py

Open dkuschmierz opened this issue 4 years ago • 2 comments

Resetting start and end date while walking the calendar. This prevents that some events are missing if there is an all_day-Event in between some events.

Consider the following settings: startdate: 01.12.2020 00:00:00 enddate: 31.12.2020 23:59:59

Events: 10.12.2020 18:00:00 EventA 22.12.2020 AllDay EventB 31.12.2020 17:00:00 EventC

While iterating through the calendar, the enddate-settings are reseted during the allday-event to 31.12.2020 00:00:00 and then EventC is missing in the list!

dkuschmierz avatar Oct 27 '20 12:10 dkuschmierz

Codecov Report

Merging #73 into master will decrease coverage by 1.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   82.82%   81.70%   -1.12%     
==========================================
  Files           4        4              
  Lines         326      328       +2     
  Branches       77       77              
==========================================
- Hits          270      268       -2     
- Misses         31       33       +2     
- Partials       25       27       +2     
Impacted Files Coverage Δ
icalevents/icalparser.py 81.58% <100.00%> (-1.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce0581e...1069241. Read the comment docs.

codecov[bot] avatar Oct 27 '20 13:10 codecov[bot]

Resetting start and end date while walking the calendar. This prevents that some events are missing if there is an all_day-Event in between some events.

Consider the following settings: startdate: 01.12.2020 00:00:00 enddate: 31.12.2020 23:59:59

Events: 10.12.2020 18:00:00 EventA 22.12.2020 AllDay EventB 31.12.2020 17:00:00 EventC

While iterating through the calendar, the enddate-settings are reseted during the allday-event to 31.12.2020 00:00:00 and then EventC is missing in the list!

Thanks for the contribution :) Could you formalise the behaviour you change in a test?

Hultner avatar Oct 27 '20 16:10 Hultner

If I understand correctly this is solved here: https://github.com/jazzband/icalevents/pull/136

eigenmannmartin avatar Sep 09 '24 11:09 eigenmannmartin