icalevents icon indicating copy to clipboard operation
icalevents copied to clipboard

Fix for recurrence ID to override repeating events

Open mbafford opened this issue 2 years ago • 1 comments

Independent (and slightly different) PR solving the same issue as in #102 (and maybe #97 ?) - also adds a new test case specifically for this issue.

Same as @chrko, I found the test test_cest for cest.ics now returns 116 events, but that file is too large / involved to easily tell what the "right" answer is.

Looks like one of these three needs to be merged - probably #97 since it seems the most comprehensive.

mbafford avatar Mar 30 '22 17:03 mbafford

Codecov Report

Merging #110 (e51367e) into master (fdd7a02) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head e51367e differs from pull request most recent head ffb0fba. Consider uploading reports for the commit ffb0fba to get more accurate results

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files           4        4           
  Lines         362      362           
  Branches       93       93           
=======================================
  Hits          318      318           
  Misses         21       21           
  Partials       23       23           
Impacted Files Coverage Δ
icalevents/icalparser.py 88.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdd7a02...ffb0fba. Read the comment docs.

codecov[bot] avatar Mar 30 '22 17:03 codecov[bot]

Thank you very much for this implementation. I was able to verify that it was already fixed. https://github.com/jazzband/icalevents/commit/d1c11aa2e0bac0e8687861c5063a07f40c0cdcbe

eigenmannmartin avatar Sep 09 '24 11:09 eigenmannmartin