django-two-factor-auth icon indicating copy to clipboard operation
django-two-factor-auth copied to clipboard

Changing hidden input submit to facilitate hidden property not css

Open yopiti opened this issue 3 years ago • 3 comments

Setting field to hidden, to avoid conflict with pages that are not using Bootstrap as CSS framework

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

yopiti avatar Aug 11 '21 08:08 yopiti

Can you please merge this?

yopiti avatar Sep 20 '21 14:09 yopiti

The template has the comment {# hidden submit button to enable [enter] key #} above that input - does that still work with a hidden input? I can't imagine it does.

moggers87 avatar Sep 20 '21 15:09 moggers87

It does. This is tested.

yopiti avatar Sep 20 '21 15:09 yopiti

Codecov Report

Merging #427 (efe4dd6) into master (445a023) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files          62       62           
  Lines        2749     2749           
  Branches      288      288           
=======================================
  Hits         2699     2699           
  Misses         29       29           
  Partials       21       21           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 17 '22 12:09 codecov[bot]