django-two-factor-auth
django-two-factor-auth copied to clipboard
Changing hidden input submit to facilitate hidden property not css
Setting field to hidden, to avoid conflict with pages that are not using Bootstrap as CSS framework
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
Can you please merge this?
The template has the comment {# hidden submit button to enable [enter] key #}
above that input - does that still work with a hidden input? I can't imagine it does.
It does. This is tested.
Codecov Report
Merging #427 (efe4dd6) into master (445a023) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #427 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 62 62
Lines 2749 2749
Branches 288 288
=======================================
Hits 2699 2699
Misses 29 29
Partials 21 21
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more