django-simple-history icon indicating copy to clipboard operation
django-simple-history copied to clipboard

Published 20 hours ago • verified publisher icon jazzband

Pagination and filtering (new PR)

Open jurrian opened this issue 2 years ago • 7 comments

Description

This will add pagination and filtering to the simple history admin view. This is needed because it will allow more performance views on instances with many historical records. Currently it is very likely to timeout depending on the settings.

It uses the same pagination as the default in Django.

Related Issue

This PR replaces this stale PR: https://github.com/jazzband/django-simple-history/pull/1220 Most of the text of this PR is copied from the stale one.

Closes https://github.com/jazzband/django-simple-history/issues/1117 and closes https://github.com/jazzband/django-simple-history/issues/1219.

Motivation and Context

This is needed because it will allow more performance views on instances with many historical records. Currently it is very likely to timeout depending on the settings .

How Has This Been Tested?

Added a few extra tests on top of what already existed in the stale PR.

Screenshots (if appropriate):

image

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I have run the pre-commit run command to format and lint.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] I have added my name and/or github handle to AUTHORS.rst
  • [x] I have added my change to CHANGES.rst
  • [x] All new and existing tests passed.

jurrian avatar Nov 09 '23 18:11 jurrian

@ddabble @RumitAP I've created a new PR based on #1220 with some additional changes.

jurrian avatar Nov 09 '23 18:11 jurrian

@ddabble could you have a look at this? It's basically the same as #1220 that you reviewed, with a small addition to make it work.

jurrian avatar Jan 03 '24 11:01 jurrian

Any update on this? Do you need any help?

diogosilva30 avatar Feb 10 '24 01:02 diogosilva30

@ddabble ?

jurrian avatar Mar 15 '24 09:03 jurrian

@jurrian Sorry for the (very) late reply; I'm busy with some of the other PRs, currently, but this is definitely on my TODO list 🙂

ddabble avatar Mar 15 '24 18:03 ddabble

Hi guys!

How is going this feature? I'm super engaged with that, for us would be an amazing deliveryHi guys!

How is going this feature? I'm super engaged with that for us will be an amazing delivery

ferran-gutierrez avatar Jul 17 '24 10:07 ferran-gutierrez

Only needs review at the moment. Code should be complete, but needs to be tested and merged.

jurrian avatar Jul 17 '24 14:07 jurrian