django-simple-history
django-simple-history copied to clipboard
Call make dist in the Release action. Fixes #987
Try to fix #987 by executing make dist
from within the release action on GitHub.
May not work due to gpg failures. I don't have a way of testing it.
Description
Related Issue
https://github.com/jazzband/django-simple-history/issues/987
Motivation and Context
To avoid missing wheel packages on PyPI and unify the build process regardless in which environment it happens.
How Has This Been Tested?
It hasn't been tested.
Screenshots (if appropriate):
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [ ] I have run the
pre-commit run
command to format and lint. - [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [x] I have added my name and/or github handle to
AUTHORS.rst
- [ ] I have added my change to
CHANGES.rst
- [x] All new and existing tests passed.
@jeking3 can you review and comment on this? Possibly test the github action?
Codecov Report
Merging #1007 (cb0726f) into master (6325659) will decrease coverage by
0.00%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
- Coverage 97.65% 97.65% -0.01%
==========================================
Files 23 23
Lines 1151 1149 -2
Branches 222 222
==========================================
- Hits 1124 1122 -2
Misses 12 12
Partials 15 15
Impacted Files | Coverage Δ | |
---|---|---|
simple_history/utils.py | 100.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3070deb...cb0726f. Read the comment docs.
ping. any news here ?
I can check this out this weekend.
Don't think this will work with gpg failures. I'd rather just get rid of the github action and release manually to do it right