django-redis icon indicating copy to clipboard operation
django-redis copied to clipboard

Issue #598 extend support for the hashmap functions

Open rootart opened this issue 1 year ago • 4 comments

rootart avatar Jun 23 '24 10:06 rootart

Codecov Report

:x: Patch coverage is 81.91489% with 34 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 64.3%. Comparing base (f34935c) to head (0dadbb0). :warning: Report is 87 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_backend.py 15.8% 32 Missing :warning:
django_redis/client/default.py 98.5% 1 Missing :warning:
django_redis/client/sharded.py 98.7% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #746     +/-   ##
========================================
+ Coverage    63.3%   64.3%   +1.1%     
========================================
  Files          43      43             
  Lines        3215    3389    +174     
  Branches      244     287     +43     
========================================
+ Hits         2034    2179    +145     
- Misses       1164    1192     +28     
- Partials       17      18      +1     
Flag Coverage Δ
mypy 38.2% <40.4%> (+0.2%) :arrow_up:
tests 91.0% <99.2%> (+0.7%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 23 '24 10:06 codecov[bot]

@rootart do you have time to finish this PR? otherwise I can take it... that said, thanks for the effort you've put in this project so far, it is highly appreciated 😄

WisdomPill avatar Jan 04 '25 10:01 WisdomPill

I'm happy to come back and continue some work on the PR 😄

looks great, but please add versioning in another PR so that it can be also tested separately

Would you suggest deleting versioning, even in the newly added interfaces? There is definitely a dependency on the hset, and the logic for the key generation must align with the other methods, like in hmget. I updated the existing functions with correct support of versioning in this PR https://github.com/jazzband/django-redis/pull/768 if we decide to start with it first.

rootart avatar Mar 25 '25 21:03 rootart

It seems like some work is duplicated; could you please take a look at my PR as well? @rootart @WisdomPill

2ykwang avatar Mar 28 '25 14:03 2ykwang