django-redis icon indicating copy to clipboard operation
django-redis copied to clipboard

Add option flags nx, xx, gt, lt for expire and pexpire

Open sauravsharma1998 opened this issue 1 year ago • 6 comments

sauravsharma1998 avatar Feb 25 '24 12:02 sauravsharma1998

Codecov Report

Attention: Patch coverage is 25.92593% with 40 lines in your changes missing coverage. Please review.

Project coverage is 62.6%. Comparing base (f34935c) to head (c0cc303). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
django_redis/client/sharded.py 12.5% 28 Missing :warning:
tests/test_backend.py 0.0% 12 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #733     +/-   ##
========================================
- Coverage    63.3%   62.6%   -0.6%     
========================================
  Files          43      43             
  Lines        3215    3263     +48     
  Branches      244     244             
========================================
+ Hits         2034    2042      +8     
- Misses       1164    1204     +40     
  Partials       17      17             
Flag Coverage Δ
mypy 37.8% <14.9%> (-0.3%) :arrow_down:
tests 90.3% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 25 '24 12:02 codecov[bot]

@WisdomPill Can you please help. This PR failure is related to some dependency installation or test case?

sauravsharma1998 avatar Feb 25 '24 12:02 sauravsharma1998

No dependency issue, have a look at ShardedClient which has .expire() defined which means you have to change ShardedClient as well

WisdomPill avatar Feb 25 '24 12:02 WisdomPill

@WisdomPill Could you please review the PR as per your convenience.

sauravsharma1998 avatar Feb 25 '24 13:02 sauravsharma1998

In Progress https://github.com/jazzband/django-redis/issues/730

sauravsharma1998 avatar Feb 25 '24 13:02 sauravsharma1998

@WisdomPill Could you please review this PR?

sauravsharma1998 avatar Jul 04 '24 18:07 sauravsharma1998