django-redis icon indicating copy to clipboard operation
django-redis copied to clipboard

Passing username to redis arguments

Open joachimBurket opened this issue 2 years ago • 6 comments

resolves #656

joachimBurket avatar Mar 02 '23 16:03 joachimBurket

I added the changelog and a test. I wasn't sure where to test the connection params so I renamed the test_connection_string.py file in test_connection_params.py and added it there with the test of the URL.

joachimBurket avatar Mar 06 '23 16:03 joachimBurket

ping ;)

joachimBurket avatar Mar 22 '23 15:03 joachimBurket

I would love to have tests to connect to a server with credentials

WisdomPill avatar Mar 23 '23 08:03 WisdomPill

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 56.3%. Comparing base (9d572cd) to head (fc3fd6c). Report is 172 commits behind head on master.

Files Patch % Lines
tests/test_connection_params.py 33.4% 18 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #657     +/-   ##
========================================
- Coverage    57.5%   56.3%   -1.1%     
========================================
  Files          39      39             
  Lines        2528    2546     +18     
  Branches       75      74      -1     
========================================
- Hits         1452    1432     -20     
- Misses       1059    1097     +38     
  Partials       17      17             
Flag Coverage Δ
mypy 33.7% <30.0%> (-0.1%) :arrow_down:
tests 83.6% <100.0%> (-<0.1%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 23 '23 08:03 codecov[bot]