django-push-notifications
django-push-notifications copied to clipboard
jazzband
Migrate from apns2 to aioapns
Disclaimer: I haven't tested this with real interactions with APNs.
The goal is to remove the indirect use of hyper (which is no longer maintained) and unblock compatibility with newer Python versions without breaking too many of the existing contracts.
I did remove the 'creds' parameter that existed in many of the functions. The value that would have been accepted is a part of apns2, so it cannot be realistically supported.
Somewhat surprising.. It seems the indentation is currently set to tabs? This PR currently converts several of the files, which may not be the right approach.
I closed this when I saw #696, but I'm re-opening it because the approaches are very different. This PR does a full replacement rather than adding an alternate APNS implementation.
i'd be following this development closely, and might have to re-base (#711) on this. Let me know if you need some help or require unblocking at some point.
I closed this when I saw #696, but I'm re-opening it because the approaches are very different. This PR does a full replacement rather than adding an alternate APNS implementation.
If I remember correctly there were some features not supported by aioapns, and i wanted to avoid breaking changes.
But it looks like async and sync versions have a lot in common so maybe we should refactor async too to share code.
apnsaio released a breaking change where now the key_file for JWT token-based auth is supposed the file content instead of the file path, please ensure you are including that change as well. https://github.com/Fatal1ty/aioapns/pull/62
