django-pipeline icon indicating copy to clipboard operation
django-pipeline copied to clipboard

More attributes to extra_context

Open matheusml opened this issue 6 years ago • 1 comments

Hey, thanks for the awesome work ❤️

I've been trying to optimize the CSS part of the bundle, by following Google's advice to Defer CSS: https://developers.google.com/web/tools/lighthouse/audits/blocking-resources

To do that, I'll have to add a disabled attribute to <link /> tags, but it seems like django pipeline currently only support the media attribute for extra_context: https://django-pipeline.readthedocs.io/en/latest/configuration.html#extra-context

If I create the PR with that, would you accept?

matheusml avatar Oct 08 '19 21:10 matheusml

Hi @matheusml, all PR are welcome. As the creator explains it:

Since this project is part of Jazzband, y’all are empowered to contribute and maintain django-pipeline.

If the functionality is relevant and all the tests pass, there is no reason why it is not merged.

Pyvonix avatar Jul 02 '20 16:07 Pyvonix