django-payments icon indicating copy to clipboard operation
django-payments copied to clipboard

Use JSONField for BasePayment.attrs

Open WhyNotHugo opened this issue 3 years ago • 7 comments

Need to wait until Django 2.2 is EOL.

WhyNotHugo avatar Mar 18 '22 17:03 WhyNotHugo

Hi! I'm actually wanting to use this, since 2.2 has already been dropped, can I give you a hand with this?

mariofix avatar May 06 '23 19:05 mariofix

I've rebased this, but it would be good to have some more testing before merging it.

WhyNotHugo avatar May 25 '23 19:05 WhyNotHugo

I'll start using it right away, and let you know, my system processes a couple thousands purchases a day, so it's a fair trial.

mariofix avatar May 25 '23 21:05 mariofix

Tests seem to still be failing on a bunch on combinations of Django + Python, so I'd hold testing it on a production environment for a bit.

WhyNotHugo avatar May 25 '23 21:05 WhyNotHugo

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (84b52c9) 78.42% compared to head (2574ae3) 77.95%.

Files Patch % Lines
payments/cybersource/__init__.py 44.44% 3 Missing and 2 partials :warning:
payments/models.py 50.00% 4 Missing :warning:
payments/stripe/__init__.py 0.00% 3 Missing :warning:
payments/paypal/__init__.py 88.88% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   78.42%   77.95%   -0.48%     
==========================================
  Files          29       29              
  Lines        1979     1964      -15     
  Branches      244      244              
==========================================
- Hits         1552     1531      -21     
- Misses        310      317       +7     
+ Partials      117      116       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 25 '23 21:05 codecov[bot]

Looks like f4dfa5e5d80b1133accbdfccd83b52f7c1f271cb is breaking some tests, but it's not clear to me why.

WhyNotHugo avatar Oct 14 '23 09:10 WhyNotHugo

Split the first commit into https://github.com/jazzband/django-payments/pull/385

WhyNotHugo avatar Oct 19 '23 08:10 WhyNotHugo